[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gnulib] memxor
From: |
Bruno Haible |
Subject: |
Re: [bug-gnulib] memxor |
Date: |
Wed, 5 Oct 2005 15:17:17 +0200 |
User-agent: |
KMail/1.5 |
Simon Josefsson wrote:
> Ok to install?
Yes. I'd try to help the compilers with not-so-good loop optimizers by
changing
for (i = 0; i < n; i++)
d[i] ^= s[i];
into
for (; n > 0; n--)
*d++ ^= *s++;
but that's a detail. Also the comment in memxor.h should say what
memxor does and what the return value is.
> I am not sure about the prototype. Should it use 'char*'? 'int*'?
'void*' is fine, analogous to memset. 'char*' is also acceptable.
'int*' implies different alignment requirements and is therefore less general.
Bruno
- memxor, Simon Josefsson, 2005/10/05
- Re: memxor, Ralf Wildenhues, 2005/10/05
- Re: [bug-gnulib] memxor,
Bruno Haible <=
- Re: memxor, Paul Eggert, 2005/10/05