[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gettimeofday() for Win32
From: |
Ralf Wildenhues |
Subject: |
Re: gettimeofday() for Win32 |
Date: |
Sun, 9 Oct 2005 08:56:50 +0200 |
User-agent: |
Mutt/1.5.9i |
Hi Martin,
If I may, a couple of comments on the code:
* Martin Lambers wrote on Sat, Oct 08, 2005 at 05:13:25PM CEST:
>
*snip*
> diff -uNr gnulib/lib/gettimeofday.h gnulib-gettimeofday/lib/gettimeofday.h
> --- gnulib/lib/gettimeofday.h 1970-01-01 01:00:00.000000000 +0100
> +++ gnulib-gettimeofday/lib/gettimeofday.h 2005-10-08 16:40:41.000000000
> +0200
> @@ -0,0 +1,41 @@
> +/* Provide gettimeofday for systems that don't have it, or
> + work around the bug in some systems whereby gettimeofday clobbers the
> + static buffer that localtime uses for it's return value. The gettimeofday
It's `its' here. :)
> + function from Mac OS X 10.0.4, i.e. Darwin 1.3.7 has this problem.
> + The tzset replacement is necessary for at least Solaris 2.5, 2.5.1, and
> 2.6.
> + Copyright (C) 2001, 2002, 2003, 2005 Free Software Foundation, Inc.
> +
> + This program is free software; you can redistribute it and/or modify
> + it under the terms of the GNU General Public License as published by
> + the Free Software Foundation; either version 2, or (at your option)
> + any later version.
> +
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License
> + along with this program; if not, write to the Free Software Foundation,
> + Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */
> +
> +#ifndef GETTIMEOFDAY_H
> +#define GETTIMEOFDAY_H
> +
> +#include <config.h>
Please do not include config.h from a header file, but always as first
include in a non-header source file, also guard the inclusion. See
here: http://lists.gnu.org/archive/html/bug-gnulib/2005-09/msg00149.html
> +
> +#ifndef HAVE_STRUCT_TIMEVAL
> +struct timeval
> +{
> + time_t tv_sec;
> + suseconds_t tv_usec;
> +};
> +#endif
> +
> +#ifndef HAVE_GETTIMEOFDAY_POSIX_SIGNATURE
> +# undef gettimeofday
> +# define gettimeofday rpl_gettimeofday
> +int gettimeofday (struct timeval *restrict tp, void *restrict tzp);
> +#endif
> +
> +#endif /* GETTIMEOFDAY_H */
*snip*
Cheers,
Ralf