[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: arcfour
From: |
Simon Josefsson |
Subject: |
Re: arcfour |
Date: |
Fri, 14 Oct 2005 15:57:43 +0200 |
User-agent: |
Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) |
Ralf Wildenhues <address@hidden> writes:
> Furthermore, if I may suggest not to sprinkle hard-coded numbers all
> over the place. How about something like this
> #define ARCFOUR_BLOCKBITS 8
> #define ARCFOUR_BLOCKSIZE (1 << ARCFOUR_BLOCKBITS)
> #define ARCFOUR_BLOCKMASK (ARCFOUR_BLOCKSIZE - 1)
Wasn't that backwards? Shouldn't it be:
#define ARCFOUR_BLOCK_SIZE 8
#define ARCFOUR_BLOCK_BITS (1 << ARCFOUR_BLOCKSIZE)
#define ARCFOUR_BLOCK_MASK (ARCFOUR_BLOCKBITS - 1)
?
Symbols called *SIZE are usually measured in bytes.
I have made this change in my local copy. (As well as adding a SPC
for easier reading..)
- arcfour, Simon Josefsson, 2005/10/13
- Re: arcfour, Ralf Wildenhues, 2005/10/14
- Re: arcfour, Simon Josefsson, 2005/10/14
- Re: arcfour,
Simon Josefsson <=
- Re: arcfour, Stepan Kasal, 2005/10/14
- Re: arcfour, Simon Josefsson, 2005/10/14
- Re: arcfour, Paul Eggert, 2005/10/14
- Re: arcfour, Bruno Haible, 2005/10/14
- Re: arcfour, Simon Josefsson, 2005/10/14
- Re: arcfour, Paul Eggert, 2005/10/14