[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] use unlocked io in getdelim
From: |
Simon Josefsson |
Subject: |
Re: [PATCH] use unlocked io in getdelim |
Date: |
Wed, 27 Aug 2008 15:47:14 +0200 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> The number of deletions makes it yummy...
I like it, although in order to deprecate the current implementation,
I'd like to see getndelim2 solve this problem:
1) LGPL license compatibility
2) Portability: getndelim2 uses freadptr and freedseek which appears
non-portable by design (or?) -- having a getline that can be compiled
on any C89/POSIX system can be useful
3) Stack size usage, freadseek uses a 4kb large buffer
If 1) can be resolved I think we could make the 'getline' module use
getndelim2 by default. That will optimize for the normal case.
However, to deal with 2) and 3) I would prefer if the current code stays
around. It could be moved to a 'getline-portable' module.
Possibly the future getline module could test whether the
freadptr/freadseek modules work on the platform and use getndelim2 if
so, and otherwise fall back on the getline-portable module.
Thanks,
Simon
- Re: [PATCH] use unlocked io in getdelim, (continued)
- Re: [PATCH] use unlocked io in getdelim, Eric Blake, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Paolo Bonzini, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Paolo Bonzini, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Paolo Bonzini, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Eric Blake, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Paolo Bonzini, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Jim Meyering, 2008/08/28
- Re: getndelim2 license, Bruno Haible, 2008/08/28
- Re: getndelim2 license, Paolo Bonzini, 2008/08/29
- Re: getndelim2 license, Jim Meyering, 2008/08/29
- Re: [PATCH] use unlocked io in getdelim,
Simon Josefsson <=
- Re: [PATCH] use unlocked io in getdelim, Paolo Bonzini, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Simon Josefsson, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Paolo Bonzini, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Simon Josefsson, 2008/08/27
- Re: [PATCH] use unlocked io in getdelim, Bruno Haible, 2008/08/28
- Re: [PATCH] use unlocked io in getdelim, Simon Josefsson, 2008/08/28
- Re: [PATCH] use unlocked io in getdelim, Bruno Haible, 2008/08/29
- Re: [PATCH] use unlocked io in getdelim, Simon Josefsson, 2008/08/29