[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: unistr use of undefined macros

From: Ludovic Courtès
Subject: Re: unistr use of undefined macros
Date: Fri, 10 Dec 2010 09:57:03 +0100
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (gnu/linux)

Hi Eric,

Eric Blake <address@hidden> writes:

> On 12/07/2010 02:24 PM, Ludovic Courtès wrote:
>> Hello,
>> Commit c98cb289 changed #ifdefs in unistr.in.h to #ifs.  As a
>> side-effect, this prevents compilation of users of this file, such as
>> Guile, with ‘-Wundef’:
> Unfortunately, that points to a bug in guile.
> Gnulib is explicitly documented as being incompatible with -Wundef; and
> while you may choose to use it for the rest of your project, you should
> not use it for gnulib files.

That’s what Guile is doing already.

The error here is when *using* <unistr.h> from libguile, which is
compiled with -Wundef.

> See for example how coreutils sets up two distinct CFLAGS, a stricter
> one for coreutils files in src/ [1] and a looser one for gnulib files in
> lib/ [2]:

I just changed <http://hydra.nixos.org/jobset/gnu/coreutils-master/> so
that Coreutils is built with ‘--enable-gcc-warnings’, and it builds


--8<---------------cut here---------------start------------->8---
$ grep -r 'unistr.[ch]' . ; echo $?
--8<---------------cut here---------------end--------------->8---

(This is in a pristine checkout, without Gnulib in here.)

So no wonder it doesn’t hit that problem.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]