[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Question about critical_factorization() in the Two-Way algorithm

From: Eric Blake
Subject: Re: Question about critical_factorization() in the Two-Way algorithm
Date: Wed, 15 Dec 2010 16:53:08 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7

On 12/15/2010 04:48 PM, Eric Blake wrote:
> On 12/15/2010 03:23 PM, Pádraig Brady wrote:
>>>> I spoke too soon.  We would also need to patch m4/memmem.m4 to actually
>>>> perform the empty needle verification in the memmem-simple case.
>>> I also noticed the empty needle verification didn't
>>> check that the correct pointer was returned,
>>> and only checked for !NULL.  So I rolled that
>>> fix into the attached reorg.
>> I've rebased the attached memmem reorg patch
>> which splits correctness checks from performance checks.
>> Subject: [PATCH] memmem: rearrange memmem and expand memmem-simple modules
>> Move all functional checks to memmem-simple so that one has
>> a fully functional memmem by using just this module.
>> Restrict the memmem module to performance checks only.
>> Document exactly how the memmem and memmem-simple modules
>> relate to each other.
> Thanks for reviving this.

Oh, I meant to add: yes, this looks fine.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]