[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: more select-tests updates

From: Paolo Bonzini
Subject: Re: more select-tests updates
Date: Mon, 27 Dec 2010 17:58:39 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6

On 12/25/2010 01:49 AM, Bruno Haible wrote:
1) The code for pipe() on Win32 is now in module 'pipe-posix'. And 'pipe-posix'
depends on 'unistd'.


2) The arguments passed to function connect_to_socket() are true and false.
So it's actually a 'bool' argument.


3) Because at least some Linux versions return in the timeout parameter the
unslept time (see<http://linux.die.net/man/2/select>), it is good practice
to not reuse a 'struct timeval' from a previous select() call for the next
select() call. Even though in this case the unslept time is probably
always zero, better use the safe way of coding.

Not really sure it's worth changing (the unslept time cannot be anything but zero---it would be a bug if otherwise!)... but since the patch is done, fine.

4) A couple of comments for do_select(), since this function is used in all
the tests. (The reader may not be familiar with poll().)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]