Re: [PATCH] bootstrap: support --no-git option

[Eric Blake]

On 01/20/2011 11:54 AM, Eric Blake wrote:
> @@ -64,6 +64,9 @@ Options:
>   --force                  Attempt to bootstrap even if the sources seem
>                            not to have been checked out.
>   --skip-po                Do not download po files.
> + --no-git                 Do not update gnulib using git. Requires that
> +                          --gnulib-srcdir points to a complete gnulib source
> +                          tree

There's a (minor) fly in the ointment, at least for testing this patch.

If you are using autopoint from gettext 0.18 or newer, and gettext was
built with git rather than CVS support, then autopoint requires a
working git, and ./bootstrap invokes autopoint.  So I was unable to
fully test this patch (but did get so far as completing the copying of
gnulib files from a static checkout, after using
  printf '#!/bin/sh\nfalse\n' > ~/bin/git
to put a bogus git on my path.

But, assuming you really are on a system without git, then you can also
assume that gettext either pre-dates 0.18, or was built with cvs instead
of git support.  So I don't see anything to change in this gnulib patch.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature