bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] fnmatch: avoid compiler warning


From: Eric Blake
Subject: [PATCH] fnmatch: avoid compiler warning
Date: Wed, 18 May 2011 13:15:37 -0600

Detected on Ubuntu 10.04, where the glibc fnmatch fix is not yet
present; also reproduced via:
$ gl_cv_func_fnmatch_posix=no CFLAGS=-Wall \
    ./gnulib-tool --with-tests --test fnmatch

In file included from gllib/fnmatch.c:172:0:
gllib/fnmatch_loop.c: In function ‘internal_fnmatch’:
gllib/fnmatch_loop.c:203:28: error: initialization discards qualifiers from 
pointer target type
gllib/fnmatch_loop.c:204:28: error: initialization discards qualifiers from 
pointer target type

* lib/fnmatch_loop.c (FCT): Use correct type.
Reported by Matthias Bolte.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog          |    6 ++++++
 lib/fnmatch_loop.c |    4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index ffea473..99e2c3e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-05-18  Eric Blake  <address@hidden>
+
+       fnmatch: avoid compiler warning
+       * lib/fnmatch_loop.c (FCT): Use correct type.
+       Reported by Matthias Bolte.
+
 2011-05-13  Jim Meyering  <address@hidden>

        maint.mk: three new prohibit_<HDR>_without_use rules
diff --git a/lib/fnmatch_loop.c b/lib/fnmatch_loop.c
index 1fb246f..8334491 100644
--- a/lib/fnmatch_loop.c
+++ b/lib/fnmatch_loop.c
@@ -200,8 +200,8 @@ FCT (const CHAR *pattern, const CHAR *string, const CHAR 
*string_end,
         case L_('['):
           {
             /* Nonzero if the sense of the character class is inverted.  */
-            CHAR *p_init = p;
-            CHAR *n_init = n;
+            const CHAR *p_init = p;
+            const CHAR *n_init = n;
             register bool not;
             CHAR cold;
             UCHAR fn;
-- 
1.7.4.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]