[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [libvirt] [PATCH] Pass a correct pointer type to localtime_r(3).
From: |
Eric Blake |
Subject: |
Re: [libvirt] [PATCH] Pass a correct pointer type to localtime_r(3). |
Date: |
Tue, 04 Sep 2012 17:21:24 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 |
On 09/04/2012 11:03 AM, Paul Eggert wrote:
>
> For this particular case, though, how about if we avoid
> the problem entirely? libvirt doesn't need to use struct
> timeval here at all. I'd use the following (untested) patch:
> it makes libvirt smaller and probably faster, and it ports
> to OpenBSD without messing with gnulib:
Looks similar to Jasper's original proposal, but with the benefit of
avoiding the buggy 'struct timeval' altogether. ACK and pushed. Paul,
I listed you in AUTHORS; if you have any preference for an alternate
name or email listing, let me know.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature