[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/1] Reduce footprint of xstrtol module

From: Bruno Haible
Subject: Re: [PATCH 0/1] Reduce footprint of xstrtol module
Date: Sat, 07 Dec 2019 10:51:35 +0100
User-agent: KMail/5.1.3 (Linux/4.4.0-166-generic; KDE/5.18.0; x86_64; ; )

Hi Pino,

> > It is possible to have several modules share the same .h file. For example,
> > <math.h> is used by many modules. If you leave xstrtol.h as is, users of the
> > module don't need to change their source code, they only need to import the
> > new module 'xstrtol-error'.
> > A separate .h file, on the other hand, provides a more orthogonal code
> > structure.
> Yes, this was a conscious decision, because of the <getopt.h> include
> in xstrtol.h: since the goal was to not require it for users of
> xstrto*, as it is not required for who does not use xstrtol_fatal().
> If I leave xstrtol.h as it was, then I still need to keep getopt-gnu
> as required dependency for xstrtol.

I see. Makes sense.

I've pushed your patch. And reworded the NEWS entry; which modules a module
pulls in automatically is not something a gnulib users needs to know about.

2019-12-07  Bruno Haible  <address@hidden>

        Reword NEWS entry.
        * NEWS: Reword the latest NEWS entry.

diff --git a/NEWS b/NEWS
index c0fe790..30bb223 100644
--- a/NEWS
+++ b/NEWS
@@ -3,15 +3,6 @@ Important general notes
 Date        Modules         Changes
-2019-12-07  userspec        The xstrtol_fatal is moved away from the xstrtol
-            xstrtoimax      module to a new xstrtol-error module. Because of
-            xstrtol         this, using xstrtol or any of the modules using it
-            xstrtoll        does not pull automatically the exitfail, error,
-            xstrtoumax      getopt-gnu, and gettext-h modules.
-2019-03-16  fatal-signal    The function that you pass to at_fatal_signal now
-                            takes the signal as argument.
 2019-02-14  gnulib-tool     If you use multiple --local-dir options at once:
                             The first one now has the highest priority, not the
                             last one.
@@ -61,8 +52,16 @@ User visible incompatible changes
 Date        Modules         Changes
+2019-12-07  xstrtol         This module no longer defines the function
+            xstrtoll        'xstrtol_fatal'.  Program that need this function
+            xstrtoimax      should add the module 'xstrtol-error' to the list
+            xstrtoumax      of imported modules.
 2019-05-90  verify          verify_true (deprecated 2011-06-15) is removed.
+2019-03-16  fatal-signal    The function that you pass to at_fatal_signal now
+                            takes the signal as argument.
 2019-02-02  c-strtod        This and related modules no longer define
                             the HAVE_C99_STRTOLD macro.  Programs requiring
                             standard strtold should use the strtold module.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]