bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: warnings in unit tests


From: Bruno Haible
Subject: Re: warnings in unit tests
Date: Fri, 11 Jun 2021 15:57:00 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-210-generic; KDE/5.18.0; x86_64; ; )

Eric Blake wrote:
> > +++ b/gnulib-tool
> > @@ -4275,6 +4275,14 @@ func_emit_tests_Makefile_am ()
> >    echo "   @echo '## You can ignore compiler warnings in this directory.  
> > ##'"
> >    echo "   @echo '## ---------------------------------------------------- 
> > ##'"
> >    echo
> > +  # Arrange to print a message before executing the tests in this 
> > directory.
> > +  echo "check-am: check-notice"
> > +  echo "check-notice:"
> > +  echo "   @echo '## ---------------------------------------------------- 
> > ##'"
> > +  echo "   @echo '## ------------------- Gnulib tests ------------------- 
> > ##'"
> > +  echo "   @echo '## Please report test failures to <bug-gnulib@gnu.org>. 
> > ##'"
> 
> Is it worth the longer line for "test failures in this directory"?

Yes, thanks for the suggestion. Done:


2021-06-11  Bruno Haible  <bruno@clisp.org>

        Make message in last commit more precise.
        Suggested by Eric Blake.
        * gnulib-tool (func_emit_tests_Makefile_am): Add more precision to
        'check-notice' message.

diff --git a/gnulib-tool b/gnulib-tool
index 4f97e63..63a875d 100755
--- a/gnulib-tool
+++ b/gnulib-tool
@@ -4278,10 +4278,10 @@ func_emit_tests_Makefile_am ()
   # Arrange to print a message before executing the tests in this directory.
   echo "check-am: check-notice"
   echo "check-notice:"
-  echo "       @echo '## ---------------------------------------------------- 
##'"
-  echo "       @echo '## ------------------- Gnulib tests ------------------- 
##'"
-  echo "       @echo '## Please report test failures to <bug-gnulib@gnu.org>. 
##'"
-  echo "       @echo '## ---------------------------------------------------- 
##'"
+  echo "       @echo '## 
---------------------------------------------------------------------- ##'"
+  echo "       @echo '## ---------------------------- Gnulib tests 
---------------------------- ##'"
+  echo "       @echo '## Please report test failures in this directory to 
<bug-gnulib@gnu.org>. ##'"
+  echo "       @echo '## 
---------------------------------------------------------------------- ##'"
   echo
   echo "# Clean up after Solaris cc."
   echo "clean-local:"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]