Re: [PATCH 3/3] lib/regexec: Resolve unused variable

[Paul Eggert]

On 6/18/21 8:44 AM, Darren Kenny wrote:
> The reason for this issue is that we are not building with DEBUG set and
> this in turn means that the assert() that reads the value of the
> variable match_last is being processed out.

Unfortunately I don't understand the scenario here. If not building with 
DEBUG, 'DEBUG_ASSERT (match_last != 1)' should expand to 'assume 
(match_last != 1)', which in turn should expand to something that 
evaluates the expression 'match_last != 1'. Please see this commit, 
which removed the "#ifdef" that you're proposing to re-add:

https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=79f8ee4e389f8cb1339f8abed9a7d29816e2a2d4