[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #55091] [PATCH] stop stripping comments and spaces from installed m
|
From: |
G. Branden Robinson |
|
Subject: |
[bug #55091] [PATCH] stop stripping comments and spaces from installed macro packages |
|
Date: |
Sun, 4 Jul 2021 11:48:42 -0400 (EDT) |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 |
Update of bug #55091 (project groff):
Status: In Progress => Fixed
Open/Closed: Open => Closed
Planned Release: None => 1.23.0
_______________________________________________________
Follow-up Comment #6:
commit 266f002e125fc4eeef2c38e40f660827e3064d84
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date: Mon Jul 5 01:38:55 2021 +1000
Remove the stripper script and its vestiges.
* contrib/hdtbl/hdmisc.tmac:
* contrib/hdtbl/hdtbl.tmac:
* contrib/mom/om.tmac:
* tmac/doc.tmac:
* tmac/e.tmac:
* tmac/mdoc/doc-common:
* tmac/mdoc/doc-ditroff:
* tmac/mdoc/doc-nroff:
* tmac/mdoc/doc-syms: Remove `%beginstrip` comment.
* tmac/strip.sed: Delete.
* tmac/tmac.am (EXTRA_DIST): Stop shipping `strip.sed`.
Fixes <https://savannah.gnu.org/bugs/?55091>.
commit ee41d36200ffc989eac09e65db7537bf59dd1c62
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date: Sun Jul 4 23:56:18 2021 +1000
Skip the stripper, part 3/3 (mdoc). [part 3c]
* tmac/doc.tmac:
* tmac/mdoc/doc-common:
* tmac/mdoc/doc-ditroff:
* tmac/mdoc/doc-nroff:
* tmac/mdoc/doc-syms: Bracket macro definitions tightly with `eo` and
`ec` requests since they were written under this assumption. The
files in general were also drafted under the assumption that they'd be
stripped, so `eo` was in effect for broad swaths of the file including
portions outside of any macro definition where comments were used.
But comments are expressed using the escape character! So we got
warnings about an undefined '\"' macro, and that was just the
beginning of a wrecking ball of trouble that smashed through the
implementation. Some--but not all--string definitions (and
appendments) needed to be bracketed with `eo` and `ec` as well, to
delay interpolation of embedded string names that are not defined
until macros interpolate them later. I did what appeared necessary to
pass our tests and keep -Tutf8 and -Tps renderings of
tmac/groff_mdoc.7 from changing from their pre-stripped output.
Subtle bugs might linger, but some won't be the fault of the
unstripping process. (For instance, try provoking a usage message on
the `Hf` macro.)
commit 24602f42e209e0565e778773a9d91c12eb3a921d
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date: Sun Jul 4 19:54:23 2021 +1000
Skip the stripper, part 3/3 (mdoc). [part 3b]
* tmac/tmac.am (TMACNORMALFILES): Add `doc-old.tmac` and `doc.tmac`.
(TMACUNSTRIPFILES, TMACSTRIPFILES): Delete variables.
(dist_tmac_DATA): Drop `$(TMACUNSTRIPFILES)`.
(nodist_tmac_DATA): Drop `$(TMACSTRIPFILES)`.
(TMACMDOCSTRIPFILES): Rename...
(TMACMDOCFILES): ...to this.
(nodist_mdoc_DATA, MOSTLYCLEANFILES): Reflect above rename.
(nodist_mdoc_DATA): Rename...
(dist_mdoc_DATA): ...to this.
(TMACMDOCUNSTRIPFILES): Delete variable.
(EXTRA_DIST): Drop `$(TMACMDOCUNSTRIPFILES)`.
($(TMACSTRIPFILES), $(TMACMDOCSTRIPFILES)): Drop targets.
WARNING: This commit fails two mdoc tests.
commit ac6080e394100a8ff441b0cb0101be9eb76331ca
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date: Sun Jul 4 19:48:25 2021 +1000
Skip the stripper, part 3/3 (mdoc). [part 3a]
* tmac/doc-old.tmac-u:
* tmac/doc.tmac-u:
* tmac/mdoc/doc-common-u:
* tmac/mdoc/doc-ditroff-u:
* tmac/mdoc/doc-nroff-u:
* tmac/mdoc/doc-syms-u: Rename these...
* tmac/doc-old.tmac:
* tmac/doc.tmac:
* tmac/mdoc/doc-common:
* tmac/mdoc/doc-ditroff:
* tmac/mdoc/doc-nroff:
* tmac/mdoc/doc-syms: ...to these.
WARNING: This commit will not build.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?55091>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/