[bug #52463] anything that talks to standard error should identify itself

[G. Branden Robinson]

Follow-up Comment #3, bug #52463 (project groff):


commit f67c5e59582f4b9c19d2a8140be373d1676ca355
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Feb 26 22:47:13 2022 +1100

    [xtotroff]: Trivially refactor.
    
    * src/utils/xtotroff/xtotroff.c: Boolify.  Include `stdbool.h` and
      `errno.h` headers.
    
      (charExists, CanonicalizeFontName, FontNamesAmbiguous, MapFont):
      Boolify.  Demote return type from `int` to `bool` and return Boolean
      instead of integer literals.
    
      (FontNamesAmbiguous, main): Reorder equality comparisons with simple
      left-hand sides to avoid inadvertent lvalue assignments.
    
      (FontNamesAmbiguous, MapFont): Refer to font name as "invalid", not
      "bad", in diagnostic messages.
    
      (MapFont, main): Use `strerror()` instead of `perror()` so that
      diagnostics include the program name and an indication of problem
      severity.
    
      (MapFont): Compare `FILE` stream pointer to `NULL` instead of treating
      it as a Boolean.
    
      (main): Use `EXIT_SUCCESS` and `EXIT_FAILURE` constants from C library
      instead of integer literals for exit status.
    
    The strerror() bit continues the long process of fixing Savannah #52463.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?52463>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/