[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [coreutils] [PATCH] sort: tune and refactor --debug code, and fix mi
|
From: |
Eric Blake |
|
Subject: |
Re: [coreutils] [PATCH] sort: tune and refactor --debug code, and fix minor underlining bug |
|
Date: |
Thu, 05 Aug 2010 14:46:04 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100803 Red Hat/3.1.2-1.el6 Mnenhy/0.8.3 Thunderbird/3.1.2 |
On 08/05/2010 02:29 PM, Paul Eggert wrote:
> * tests/misc/sort-debug-keys: Fix test case: "--Mi-1" is not
> a number, so its first character should not be underlined when
> debugging a numeric sort.
Hmm - we document that '1M' and 'M' are synonyms in the 'Block size'
node of the manual, so when doing a -h numeric sort, I think the M
should be underlined. But only for -h; plain -n should not underline
the M. On the other hand, I just noticed this bug pre-patch, and
haven't yet applied the patch to see if it is still present:
$ echo '1Mi Mi' | ../coreutils/src/sort --debug -k1,1h -k2,2h
../coreutils/src/sort: using `en_US.UTF-8' sorting rules
1Mi Mi
___
__
______
Without a suffix B, I don't think the lone 'i' should be considered as
part of the -h suffix.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature