Re: [coreutils] [PATCH] maint: avoid a hung 'make syntax-check' in VPATH build

[Eric Blake]

On 08/10/2010 11:04 AM, Eric Blake wrote:
> * cfg.mk (sc_system_h_headers): Look for files in correct location.
> ---
>
> OK to commit?  Without it, 'make syntax-check' hangs on a VPATH
> build, since the grep inside $() has no matches, meaning the
> grep outside is passed no file names and tries to read stdin.
>
>   cfg.mk |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cfg.mk b/cfg.mk
> index dff5de5..ae5f819 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -129,7 +129,7 @@ sc_system_h_headers: .re-list
>           trap 'rc=$$?; rm -f .re-list; exit $$rc' 0;                   \
>           $(gl_trap_);                                                  \
>           grep -nE -f .re-list                                          \
> -             $$($(VC_LIST_EXCEPT) | grep '^src/')                      \
> +             $$($(VC_LIST_EXCEPT) | grep '^\($(srcdir)/\)\?src/')      \

No answer, so I pushed this as well as an update to the gnulib submodule 
so as to avoid warnings for those building with latest-and-greatest 
autoconf.git:

* gnulib 91fd3b1...a228f53 (38):
  > lseek: fix link test
  > include_next: silence autoconf 2.68 warning
  > acl: fix compilation test
  > Modernize AC_TRY_RUN invocations.
  > Modernize AC_TRY_LINK invocations.
  > Modernize AC_TRY_COMPILE invocations.
  > stat-time: relax license LGPL
  > autoupdate
  > poll: return immediately on POLLHUP.
  > Fix test-unlinkat, test-rmdir failure on AIX 5.3.
  > stdbool: avoid spurious failure with modern xlc
  > getloadavg: simplify code
  > getloadavg: don't define SVR4 on cygwin
  > priv-set: fix comment
  > priv-set: fix comments
  > stdbool: avoid rejecting clang
  > argz: fix shell quoting issue
  > poll, select: handle ERROR_BROKEN_PIPE.
  > fts: allow compilation with C++
  > autoupdate
  > Fix gnulib-tool sed script de-commentation for AIX sed.
  > update from texinfo
  > autoupdate
  > test-stddef: test for (some) offsetof bugs
  > stpncpy: Allow stpncpy to be defined as a macro.
  > Rename module 'memxfrm' to 'amemxfrm'.
  > Tests for module 'astrxfrm'.
  > New module 'astrxfrm'.
  > Document not_eol.
  > Document not_eol and remove mention of regex.c.
  > Ignore one more generated index from makeinfo.
  > git-merge-changelog: add doc relating to use with bzr and hg.
  > pthread: fix pthread.h creation for srcdir != builddir
  > avoid some overlong lines from posix urls, etc.
  > autoupdate
  > missed commit
  > autoupdate
  > strtod: fix const diagnostic

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org