[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] mktemp: clarify intent and avoid unusual comma use
From: |
Pádraig Brady |
Subject: |
Re: [PATCH] mktemp: clarify intent and avoid unusual comma use |
Date: |
Fri, 22 Jul 2011 14:14:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 |
On 20/07/11 17:53, Tarmigan Casebolt wrote:
> * src/mktemp.c: The comma syntax of the previous code (introduced in
> be6120b5) was unusual and hard for a human to parse. The underlying
> logic is simple even if it does take a few more lines of code, so make
> the code easier for a human to read.
We discussed this previously and decided adding 4 lines
was not warranted to avoid the compiler warning.
> In addition, (though this case is likely fine) some compilers may have
> unexplored corner cases with comma separated statements. See
> http://blog.regehr.org/archives/558
> for a further discussion.
Thanks for the info though.
cheers,
Pádraig.
- Prev by Date:
Re: [PATCH] cat, cp, mv, install, split: Set the minimum IO block size used, to 64KiB
- Next by Date:
Re: [PATCH] test-select.h: avoid warning from gcc's -Wmissing-declarations
- Previous by thread:
[PATCH] mktemp: clarify intent and avoid unusual comma use
- Next by thread:
[PATCH] cat, cp, mv, install, split: Set the minimum IO block size used, to 64KiB
- Index(es):