Re: Shred: Add recursion operations [PATCH]

[Jim Meyering]

Eric Blake wrote:

> On 12/09/2011 10:52 AM, Amr Ali wrote:
>> Hi Eric,
>
> Please don't top-post on technical lists.
>
>>
>> I completely agree about the philosophy. But ...
>>
>> 1) I've seen a comment at shred.c:26 that indicates adding -R/-r/--recursive 
>> as
>> a TODO.
>
> Hmm, we probably ought to nuke that comment instead, unless there are
> other implementations of shred that already provide -r.

Thanks for mentioning it.
That comment is no longer useful, so I'll remove it with this:


>From da4793e949363242400ad10bc739e3db4319755f Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Fri, 9 Dec 2011 20:12:44 +0100
Subject: [PATCH] maint: remove a misleading comment from shred.c

* src/shred.c: Remove obsolete TODO comment.  The first two and the
last item were done, adding --recursive (-r) is neither necessary
nor appropriate, and I don't want to add --interactive.  I don't
see a need for the others.  Prompted by comments from Amr Ali.
---
 THANKS.in   |    1 +
 src/shred.c |   11 -----------
 2 files changed, 1 insertions(+), 11 deletions(-)

diff --git a/THANKS.in b/THANKS.in
index afed5d4..3541c6f 100644
--- a/THANKS.in
+++ b/THANKS.in
@@ -38,6 +38,7 @@ Alexey Solovyov                     address@hidden
 Alexey Vyskubov                     address@hidden
 Alfred M. Szmidt                    address@hidden
 Ambrose Feinstein                   address@hidden
+Amr Ali                             address@hidden
 Andi Kleen                          address@hidden
 Andre Novaes Cunha                  address@hidden
 Andreas Frische                     address@hidden
diff --git a/src/shred.c b/src/shred.c
index a2365b0..fd57c38 100644
--- a/src/shred.c
+++ b/src/shred.c
@@ -18,17 +18,6 @@

    Written by Colin Plumb.  */

-/* TODO:
-   - use consistent non-capitalization in error messages
-   - add standard GNU copyleft comment
-
-  - Add -r/-R/--recursive
-  - Add -i/--interactive
-  - Reserve -d
-  - Add -L
-  - Add an unlink-all option to emulate rm.
- */
-
 /*
  * Do a more secure overwrite of given files or devices, to make it harder
  * for even very expensive hardware probing to recover the data.
--
1.7.8.110.g4cb5d1