[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: use stat-size module from gnulib
From: |
Jim Meyering |
Subject: |
Re: [PATCH] maint: use stat-size module from gnulib |
Date: |
Wed, 04 Jan 2012 17:31:59 +0100 |
Eric Blake wrote:
> On 06/11/2011 05:02 AM, James Youngman wrote:
>> * src/system.h: Definitions of ST_* macros have moved into the
>> gnulib module stat-size (specifically, the header file
>> stat-size.h), so remove them from here.
>> * src/truncate.c: Include stat-size.h.
>> * src/stat.c: Likewise.
>> * src/shred.c: Likewise.
>> * src/ls.c: Likewise.
>> * src/du.c: Likewise.
>> * src/ioblksize.h: New file. Move definition of io_blksize out of
>> system.h so that system.h does not have to include stat-size.h.
>> * src/cat.c: Include ioblksize.h.
>> * src/split.c: Likewise.
>> * src/copy.c: Include both stat-size.h and ioblksize.h.
>
> How much of this patch is still worth applying on today's coreutils.git?
Hi Eric,
Maybe you mean some other patch?
It looks like it was applied back in June:
commit 5a3879ad03ff926e504b48694d8e589089154369
Author: James Youngman <address@hidden>
Date: Sat Jun 11 16:28:34 2011 +0100
maint: use stat-size module from gnulib
* gnulib: Update to latest.
* src/system.h: Definitions of ST_* macros have moved into the
gnulib module stat-size (specifically, the header file
stat-size.h), so remove them from here.
* src/truncate.c: Include stat-size.h.
* src/stat.c: Likewise.
* src/shred.c: Likewise.
* src/ls.c: Likewise.
* src/du.c: Likewise.
* src/ioblksize.h: New file. Move definition of io_blksize out of
system.h so that system.h does not have to include stat-size.h.
* src/cat.c: Include ioblksize.h.
* src/split.c: Likewise.
* src/copy.c: Include both stat-size.h and ioblksize.h.
* src/Makefile.am (noinst_HEADERS): Add ioblksize.h.