[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] rm: new option (-d) to remove empty directories
From: |
Jim Meyering |
Subject: |
Re: [PATCH] rm: new option (-d) to remove empty directories |
Date: |
Mon, 23 Jan 2012 16:20:48 +0100 |
Eric Blake wrote:
> On 01/23/2012 05:22 AM, Krzysztof Goj wrote:
>> It was raised in the Google+ discussion that -d flag has been added to
>> BSD code base in 1990.
>> I checked the man pages of FreeBSD, NetBSD, OpenBSD and Mac OS X and
>> the -d option is there.
>
> That's the most convincing argument for adding this, even though it is
> somewhat redundant with rmdir(1).
>
>>
>> I attach output of `git format-patch --stdout -1`, you can also
>> get the changes from my github (https://github.com/goj/coreutils,
>> rm-d branch).
>
> Thanks; right now, the biggest remaining hurdle is copyright assignment.
> I will send you details off-list to get that started.
>
>>
>> This is my first patch to the coreutils, so please review it carefully.
>
> I won't review it until your assignment is in place (so as not to taint
> myself if we have to reimplement it from scratch).
For the record, I have explicitly ignored your changes to
rm.c and remove.c, for now, for the same reason.