Re: [PATCH] maint: remove some redundant automake _SOURCES

[Jim Meyering]

Pádraig Brady wrote:
> commit d955282324f7350e59fb83b85092dfad61a86eb9
> Author: Pádraig Brady <address@hidden>
> Date:   Thu Jan 26 00:00:55 2012 +0000
>
>     maint: remove some redundant automake _SOURCES
>
>     * src/Makefile.am: Remove auto generated entries.

ACK.
It'd be nice if automake would warn about those.
I suppose you found them by inspection?

> diff --git a/src/Makefile.am b/src/Makefile.am
> index 3f11818..df9995d 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -473,7 +473,6 @@ dir_SOURCES = ls.c ls-dir.c
>  vdir_SOURCES = ls.c ls-vdir.c
>  id_SOURCES = id.c group-list.c
>  groups_SOURCES = groups.c group-list.c
> -ln_SOURCES = ln.c
>  ls_SOURCES = ls.c ls-ls.c
>  chown_SOURCES = chown.c chown-core.c
>  chgrp_SOURCES = chgrp.c chown-core.c
> @@ -491,9 +490,7 @@ stat_SOURCES = stat.c find-mount-point.c
>
>  uname_SOURCES = uname.c uname-uname.c
>  arch_SOURCES = uname.c uname-arch.c
> -nproc_SOURCES = nproc.c
>
> -md5sum_SOURCES = md5sum.c
>  md5sum_CPPFLAGS = -DHASH_ALGO_MD5=1 $(AM_CPPFLAGS)
>  sha1sum_SOURCES = md5sum.c
>  sha1sum_CPPFLAGS = -DHASH_ALGO_SHA1=1 $(AM_CPPFLAGS)