Re: [PATCHv2] build: speed up configure for releases

[Eric Blake]

On 03/20/2012 01:09 PM, Eric Blake wrote:
> Since most users won't be building with GNULIB_POSIXCHECK defined in
> CFLAGS, and since we can make ./configure 10% (several seconds!) faster
> by omitting the framework for a posix check, this patch makes it so
> that the framework is omitted by default, while still giving
> instructions for maintainers to re-enable it.
> 
> It's been a while since we've used GNULIB_POSIXCHECK; see this email:
> https://lists.gnu.org/archive/html/coreutils/2012-03/msg00126.html
> Some of those failures are because we are intentionally avoiding
> specific gnulib modules (that is, we have chosen not to use things
> like fprintf-posix), but until we work with gnulib to avoid particular
> warnings, wiring up an automatic GNULIB_POSIXCHECK to happend during
> 'make my-distcheck' is not feasible.
> 
> * configure.ac (gl_ASSERT_NO_GNULIB_POSIXCHECK): Conditionally
> define, according to whether $GNULIB_POSIXCHECK is in environment.
> ---
>  configure.ac |   14 ++++++++++++++
>  1 files changed, 14 insertions(+), 0 deletions(-)

Should I go ahead and apply this patch?

For reference, here's the counterpart changes to 'make my-distcheck'
that would make GNULIB_POSIXCHECK part of the release process, but which
we are not ready to apply yet:

diff --git i/dist-check.mk w/dist-check.mk
index dd30db2..229d521 100644
--- i/dist-check.mk
+++ w/dist-check.mk
@@ -151,7 +151,9 @@ my-distcheck: $(DIST_ARCHIVES) $(local-check)
        mkdir -p $(t)
        $(amtar_extract_) $(preferred_tarball_) -C $(t)
        (set -e; cd $(t)/$(distdir);                    \
-         ./configure --quiet --enable-gcc-warnings --disable-nls; \
+          GNULIB_POSIXCHECK=1 autoreconf -f;           \
+         ./configure --quiet --enable-gcc-warnings     \
+            --disable-nls CFLAGS=-DGNULIB_POSIXCHECK=1; \
          $(MAKE) AM_MAKEFLAGS='$(null_AM_MAKEFLAGS)';  \
          $(MAKE) dvi;                                  \
          $(install-transform-check);                   \


-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature