Re: [PATCH] maint: ensure PATH_MAX is set correctly

[Eric Blake]

On 03/22/2012 05:47 AM, Pádraig Brady wrote:
>> > ACK, once you also modify bootstrap.conf to call out an explicit
>> > dependency on the 'pathmax' module (right now, we're getting it
>> > implicitly via transitive closure).
>> > 
> Cool thanks.
> Adjusting that led me to:
> http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/27183/focus=27269
> 
> Updated patch attached.
> 
> cheers,
> Pádraig.
> 

> +++ b/src/system.h
> @@ -40,7 +40,11 @@ you must include <sys/types.h> before including this file
>  
>  #include <unistd.h>
>  
> +/* limits.h must come before pathmax.h because limits.h on some systems
> +   undefs PATH_MAX, whereas pathmax.h may set PATH_MAX.  */
>  #include <limits.h>
> +
> +#include "pathmax.h"

pathmax.h includes <limits.h>, precisely so that you don't have to worry
about ordering between the two headers.  Therefore, your comments about
an ordering dependency aren't really accurate.

I'd be okay with the simpler:

#include <unistd.h>
#include <limits.h>

#include "pathmax.h"
#ifndef PATH_MAX
...


-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature