[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] ln: add the --relative option
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH v2] ln: add the --relative option |
|
Date: |
Thu, 22 Mar 2012 11:47:58 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
On 03/22/2012 11:29 AM, Jim Meyering wrote:
> Pádraig Brady wrote:
>> Attached is a mergeable version.
>> I'd be inclined to include this in the
>> imminent release given the unlikely impact
>> on existing code?
>
> Thanks. That is reasonable.
> I'll make another snapshot once you've pushed this.
>
>> * src/relpath.c: Refactored from realpath.c and adjusted
>> to support returning the relative path rather than just outputting.
>> * src/relpath.h: Export the relpath function.
>> * src/Makefile.am: Reference the refactored relpath module.
>> * po/POTFILES.in: Likewise.
>> * src/ln.c (usage): Mention the new option.
>> (do_link): Call the relative conversion is specified.
>
> s/is/if/ ?
>
>> (convert_abs_rel): Perform the relative conversion
>> using the refactored relpath module.
>> * src/realpath.c: Adjust to the refactored relpath module.
>> * tests/ln/relative: Add a new test.
>> * tests/Makefile.am: Reference the new test.
>> * doc/coreutils.texi: Document the new feature.
>> * NEWS: Mention the new feature.
That's a big commit; could you split it into two pieces (one to refactor
realpath and create the new file; the other to teach ln to use the new
file)?
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature