Re: df --output

[Pádraig Brady]

On 11/07/2012 08:33 AM, Bernhard Voelker wrote:
> On 11/07/2012 04:09 AM, Pádraig Brady wrote:
> > I've finished my review. Sorry for the delay.
>
> Thank you, no worries.
>
> > I've made a couple of adjustments in the attached df--output-adjustments.patch
> >
> > The first is to rename --output=total to --output=size
> > I think having `df --total --output=total` is a bit confusing?
>
> I made it 'total' to better align with 'itotal' in the inode case,
> but ambiguity with --total is a valid point.
>
> Wouldn't it be worth to s/TOTAL_FIELD/SIZE_FIELD/ then?

good point.

> > Also I've changed df --output to show the block size in the "size" header,
> > unless -h (human) is being used.  I.E. behave with this header
> > more like the traditional df output.  I think this is needed
> > as important info is lost about the units otherwise?
>
> +1
>
> > I've put the full rebased 24 item patch set here:
> > http://www.pixelbeat.org/patches/coreutils/df--output.patch.bz2
>
> Apart from the above note, it looks all good to me. Thanks.
>
> BTW: during development, I was using the attached bulk test script
> to catch regressions between df of version 8.19 and my version.
> If you want to try it, then you'll have to adapt the variables
> DF_OLD / DF_NEW at the top of the script to fit into your environment.

That verification script passes.
I've rolled the patch set up to 3 patches here:
  http://www.pixelbeat.org/patches/coreutils/df--output-merge.patch.bz2
which I'll merge later today.

thanks again!
Pádraig.