Re: [PATCH] df: port the new df test to POSIX sed, larger file systems

[Stefano Lattarini]

Hi Pádraig, Bernhard.

On 11/22/2012 12:52 PM, Pádraig Brady wrote:
>
>>   df --help > out || fail=1
>> -grep ' --output' out | sed 's/^.*\(--output\).*$/\1/;q' > out2
>> -compare exp out2 || fail=1
>> +grep ' --output' out >/dev/null || fail=1
>
Why this extra redirection to /dev/null?  I think the output from
the tests should be as verbose as possible, to simplify debugging
and analysis.  Granted, not a big deal here, but IMHO it's better
to be consistent and avoid gratuitous null redirections.

Regards,
  Stefano