[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: uniq with sort-like "--key" support
From: |
Assaf Gordon |
Subject: |
Re: uniq with sort-like "--key" support |
Date: |
Wed, 13 Feb 2013 12:34:16 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120510 Icedove/10.0.4 |
Hello Jim,
Jim Meyering wrote, On 02/13/2013 12:05 PM:
> Assaf Gordon wrote:
>> Assaf Gordon wrote, On 02/13/2013 11:45 AM:
> ...
>>> One more update with two changes:
>> ...
>> src/uniq_sort_common.h | 1096
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>
> Hi Gordon.
> Thanks a lot for working on this long-requested change.
> I don't have time to review it, but please change the name of that
> new header file. First, we use hyphens (not underscores) in file names.
> Did you consider any names that evoke "key spec parsing"?
> Then, the name would still be apropos if someday it's used by a program
> other than sort and uniq.
This was just a proof-of-concept, so I wanted to have minimal changes that
would "just work".
What would be the recommended way to compartmentalize this functionality?
1. put it in "src/key-spec-parsing.h", and have each program (e.g. uniq.c) do
"#include" ?
or
2. split it into "src/key-spec-parsing.h" and "src/key-spec-parsing.c" (with
all the "src/local.mk" associated changes) - but removing the "static" from all
the variables/functions?
or something else?
-gordon
- uniq with sort-like "--key" support, Assaf Gordon, 2013/02/11
- Re: uniq with sort-like "--key" support, Pádraig Brady, 2013/02/11
- Re: uniq with sort-like "--key" support, Assaf Gordon, 2013/02/12
- Re: uniq with sort-like "--key" support, Assaf Gordon, 2013/02/13
- Re: uniq with sort-like "--key" support, Assaf Gordon, 2013/02/13
- Re: uniq with sort-like "--key" support, Jim Meyering, 2013/02/13
- Re: uniq with sort-like "--key" support,
Assaf Gordon <=
- Re: uniq with sort-like "--key" support, Assaf Gordon, 2013/02/13
- Re: uniq with sort-like "--key" support, Pádraig Brady, 2013/02/13
- Re: uniq with sort-like "--key" support, Assaf Gordon, 2013/02/13
- Re: uniq with sort-like "--key" support (now with sort and join), Assaf Gordon, 2013/02/13
- Re: uniq with sort-like "--key" support, Pádraig Brady, 2013/02/13