Re: [PATCH] mk{dir, fifo, nod}: with -Z, create SMACK security context

[Pádraig Brady]

On 07/02/2013 09:28 AM, Bernhard Voelker wrote:
> On 07/02/2013 05:00 AM, Pádraig Brady wrote:
>> I noticed a small inconsistency in id -Z.
> 
> Thanks, good catch.
> What about enhancing the comment above, too?
> 
> -   /* If we are on a selinux-enabled kernel, no user is specified, and
> +   /* If we are on a SELinux/SMACK-enabled kernel, no user is specified, and
>     ...

done

> 
> 
> And a minor nit which I'm not sure about: shouldn't we write SMACK all
> upper-case, at least in the commit title?
> 
> - Subject: [PATCH 1/2] id: don't show smack errors unless -Z is specified
> + Subject: [PATCH 1/2] id: don't show SMACK errors unless -Z is specified
> 
> - Subject: [PATCH 2/2] maint: refactor smack interface to a separate module
> + Subject: [PATCH 2/2] maint: refactor SMACK interface to a separate module

Yes done for consistency

Both now pushed.

>> Also the HAVE_SMACK ifdefs were beginning to proliferate in the code.
> 
> In mk{dir,fifo,nod}.c:main, the variable ret and issuing the error message
> should be moved into the body of the if (context) block as shown in the
> patch below.

Looks good. Please push that too.

thanks!
Pádraig.