[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] df: fix mount list processing with unstatable mount dirs
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH] df: fix mount list processing with unstatable mount dirs |
|
Date: |
Tue, 09 Jul 2013 16:00:27 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 07/09/2013 03:12 PM, Bernhard Voelker wrote:
>
>
> On 07/09/2013 03:47 AM, Pádraig Brady wrote:
>> * src/df.c (filter_mount_list): Initialize devlist->dev_num correctly
>> when unable to stat() a mount point. This will avoid possible invalid
>> deduplication done on the list due to use of uninitialized memory.
>
> Well spotted - how did you notice?
Just though inspection, though theoretically a static
analysis tool might flag this (I've not seen it flagged
though on any static analysis run I've seen).
> Tomorrow, I'll have time for a review.
cheers,
Pádraig.