Re: [PATCH] maint: fix a memory leak in df

[Pádraig Brady]

On 07/12/2013 11:42 AM, Bernhard Voelker wrote:
> On 07/12/2013 12:32 PM, Pádraig Brady wrote:
>> On 07/12/2013 11:30 AM, Bernhard Voelker wrote:
>>> On 07/11/2013 02:53 PM, Pádraig Brady wrote:
>>>> Attached.  Note it's updated to free _all_ discarded mount items,
>>>> not just those being replaced.
>>>
>>> Hi Padraig,
>>>
>>> sorry to be late.
>>> What do you think about the following patch to give the
>>> discard_me variable a better scope?
>>
>> I considered that, but thought it clearer
>> to avoid the 'continue'.
> 
> Okay, no big deal then.
> 
> BTW: what do you think about the 'still reachable' leaks denoted
> by valgrind?  Depending on the case, the lists 'mount_list',
> 'table' and the variables 'stats' and 'columns' are not free()d.
> Avoiding that IF_LINT()-ed wouldn't be too hard.

Since IF_LINT introduces a bit of "ugliness" to the code,
I'd prefer it reserved for "definitely lost" cases.

cheers,
Pádraig.