Re: [PATCH] rm: Add number of arguments to interactive prompt

[Pádraig Brady]

On 07/19/2013 07:12 PM, Rasmus Villemoes wrote:
> Pádraig Brady <address@hidden> writes:
> 
>> I've adjusted to correctly pluralize and remove the redudant "all".
>> thanks,
> 
> Not to start painting a bikeshed,

No worries, we're good at that here :)

> but: I'm not so sure "all" is
> redundant. If prompted with "Remove 50 arguments?", I'd like to choose
> the option "yes, and if I provided more than 50 arguments (how would I
> know, the shell did most of the work), please also remove those"; the
> yesno() library function does not provide that option :-)

I see your point.
However it's unlikely that someone would be confused that
rm was removing only some of the supplied arguments.
Also it mentions "arguments" rather than files,
also suggesting this is a sanity check referring to all arguments.

> If "all" must go, "the" could take its place. With the proper
> pluralization, that would probably also make a nicer prompt in the
> n_files==1 case.

So it's not worth another commit to change further.

thanks,
Pádraig.