Re: chroot's userspec option

[Pádraig Brady]

On 03/13/2014 07:37 AM, Bernhard Voelker wrote:
> On 03/13/2014 02:47 AM, Pádraig Brady wrote:
>> Proposed patch is attached.
> 
> The patch looks good to me, but I think that whole "out-then-inside"
> thing should be mentioned in the texinfo manual.
> 
> Additionally, I think a link to
>   @node Disambiguating names and IDs
> would be nice in there (like in '@node chown invocation').
> 
> BTW:
> As id(1) is also using the leading "+" as disambiguation,
> I think that chapter should be generalized more, and also referenced
> there.

Done with the attached adjustment.
Also I've now allowed an empty --groups=""
which results in a noop rather than an error.
This seems more natural and also --userspec="" was already allowed.
Also I've added more test cases.

> BTW2:
> A side note for the info pages: it is not documented that --userspec
> also accepts the dot ('.') as separator between the user and the group,
> but this is true for chown(1), too (the other program using
> parse_user_spec for user *and* group parsing, id(1) does not).

There is already a note in "chown invocation" about the support for "."
I think we'll leave it there for now, since it's legacy and
shouldn't be used with the newer `chroot --userspec` option.

thanks!
Pádraig.

chroot-better-id-lookup-adjustment.diff
Description: Text Data