Re: chroot's userspec option

[Bernhard Voelker]

On 03/13/2014 01:17 PM, Pádraig Brady wrote:
> On 03/13/2014 07:37 AM, Bernhard Voelker wrote:
> > On 03/13/2014 02:47 AM, Pádraig Brady wrote:
> > > Proposed patch is attached.
> >
> > The patch looks good to me, but I think that whole "out-then-inside"
> > thing should be mentioned in the texinfo manual.
> >
> > Additionally, I think a link to
> >    @node Disambiguating names and IDs
> > would be nice in there (like in '@node chown invocation').
> >
> > BTW:
> > As id(1) is also using the leading "+" as disambiguation,
> > I think that chapter should be generalized more, and also referenced
> > there.
>
> Done with the attached adjustment.
> Also I've now allowed an empty --groups=""
> which results in a noop rather than an error.
> This seems more natural and also --userspec="" was already allowed.
> Also I've added more test cases.

Great, thanks.

> > BTW2:
> > A side note for the info pages: it is not documented that --userspec
> > also accepts the dot ('.') as separator between the user and the group,
> > but this is true for chown(1), too (the other program using
> > parse_user_spec for user *and* group parsing, id(1) does not).
>
> There is already a note in "chown invocation" about the support for "."
> I think we'll leave it there for now, since it's legacy and
> shouldn't be used with the newer `chroot --userspec` option.

Okay, I'm fine with that.

Re. the adjustment diff:

> @@ -16109,6 +16109,13 @@ The items in the list (names or numeric IDs) must be 
separated by commas.
>
>  @end table
>
> +The user and group name look up performed by the @option{--userspec}
> +and @option{--groups} options, is done both outside and inside

s/,// ?

> +the chroot, with successful look ups inside the chroot taking precedence.


I'm no expert in this, but the different kind of uses of
of "lookup" vs. "look up" vs. "look-up" does not look consistent
(well, a "DNS lookup" and the lookup() function are fixed terms):

  $ grep 'look[- ]*up' doc/coreutils.texi \
      | awk '/lookup/ {l1++}; /look up/ {l2++}; /look-up/ {l3++};
             END {print "lookup: ",l1, "\nlook up: ", l2, "\nlook-up: ", l3}'
  lookup:  3
  look up:  4
  look-up:  2

Otherwise: +1

Thanks & have a nice day,
Berny