coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] basename: mention that the -s option implies -a in usage


From: Bernhard Voelker
Subject: [PATCH] basename: mention that the -s option implies -a in usage
Date: Tue, 25 Mar 2014 23:41:45 +0100

* src/basename.c (usage): Mention that -s implies -a.
(main): Add "fall through" comment to case 's'.

Spotted by coverity: MISSING_BREAK.
---
 src/basename.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/basename.c b/src/basename.c
index c34ec6c..05c5c77 100644
--- a/src/basename.c
+++ b/src/basename.c
@@ -59,7 +59,7 @@ If specified, also remove a trailing SUFFIX.\n\
 
       fputs (_("\
   -a, --multiple       support multiple arguments and treat each as a NAME\n\
-  -s, --suffix=SUFFIX  remove a trailing SUFFIX\n\
+  -s, --suffix=SUFFIX  remove a trailing SUFFIX; implies -a\n\
   -z, --zero           separate output with NUL rather than newline\n\
 "), stdout);
       fputs (HELP_OPTION_DESCRIPTION, stdout);
@@ -146,6 +146,7 @@ main (int argc, char **argv)
         {
         case 's':
           suffix = optarg;
+          /* Fall through: -s implies -a.  */
 
         case 'a':
           multiple_names = true;
-- 
1.8.4.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]