coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] basename: mention that the -s option implies -a in usage


From: Bernhard Voelker
Subject: Re: [PATCH] basename: mention that the -s option implies -a in usage
Date: Wed, 26 Mar 2014 11:37:58 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 03/26/2014 11:09 AM, Pádraig Brady wrote:
On 03/25/2014 10:41 PM, Bernhard Voelker wrote:
* src/basename.c (usage): Mention that -s implies -a.
(main): Add "fall through" comment to case 's'.

Spotted by coverity: MISSING_BREAK.
______________^^^^^^^^


Cool you must be running some static analysis.

sure, see above. ;-)

I've just removed this from my own "misc fixes" branch.

please push

done:
  http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=25c2f0d617

Thanks for the review.

Have a nice day,
Berny





reply via email to

[Prev in Thread] Current Thread [Next in Thread]