coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint: ensure "Co-authored-by" in commit message has an emai


From: Bernhard Voelker
Subject: Re: [PATCH] maint: ensure "Co-authored-by" in commit message has an email address
Date: Sun, 13 Jul 2014 17:08:26 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

On 07/13/2014 04:43 PM, Pádraig Brady wrote:
> Generally we try to keep emails out of commit messages since
> they're quite ephemeral, and not subject to .mailmap etc.

Fair point.

> So I'm fine with committing this, but possibly better would
> be to update gitlog-to-changelog to query git for the address?
> Perhaps something like this would work (which also honors
> the .mailmap):
> 
>   git_email() {
>     GIT_PAGER= git log -1 --author="$1" --pretty='format:%aE'
>   }
>   echo $(git_email "Niels Möller")

So this would only work if the co-author is the author of an
older commit.  This seems to be okay, because otherwise, we'd
add an entry in THANKS.in, right?

Have a nice day,
Berny



reply via email to

[Prev in Thread] Current Thread [Next in Thread]