[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: fix invalid patch in recent commit
From: |
Pádraig Brady |
Subject: |
Re: [PATCH] maint: fix invalid patch in recent commit |
Date: |
Tue, 03 Feb 2015 10:48:59 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 03/02/15 07:35, Bernhard Voelker wrote:
> On 02/03/2015 06:12 AM, Pádraig Brady wrote:
> Good idea, thanks.
> Minor issue: depending on the state of the gnulib directory,
> the syntax-check may ask questions and probably hang:
>
> ensure_gl_diffs_apply_cleanly
> Reversed (or previously applied) patch detected! Assume -R? [n]
> Apply anyway? [n]
> 8 out of 8 hunks ignored
> gl/lib/tempname.c.diff
> To refresh run: make refresh-gnulib-patches
> cfg.mk:127: recipe for target 'sc_ensure_gl_diffs_apply_cleanly' failed
> make: *** [sc_ensure_gl_diffs_apply_cleanly] Error 1
>
> OTOH, as this is the bad case anyway, having patch asking may not be
> much of a problem.
>
> Otherwise +1, thanks again.
I added a -f option to avoid prompts.
Also I redirected errors to stderr,
and with that I pushed.
Thanks for the review.
Pádraig.