Re: [PATCH] tests: fix recent regression in tail inotify test

[Bernhard Voelker]

On 02/05/2015 05:34 PM, Pádraig Brady wrote:
> * tests/tail-2/inotify-rotate.sh (cleanup_fail_): Set fail=1
> so that failures are identified.  Regression in v8.23-63-g111a2b9
> ---
>  tests/tail-2/inotify-rotate.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/tail-2/inotify-rotate.sh b/tests/tail-2/inotify-rotate.sh
> index 452a916..556955f 100755
> --- a/tests/tail-2/inotify-rotate.sh
> +++ b/tests/tail-2/inotify-rotate.sh
> @@ -41,6 +41,7 @@ cleanup_fail()
>    cat out
>    warn_ $1
>    kill $pid
> +  fail=1
>  }
>  
>  # Perform at least this many iterations, because on multi-core systems

Good catch! How did you find this one?

BTW: the previous implementation used 'fail_ ...' which
prefixes the error diagnostic with "$ME_: ". Do you think
it's worth to change it, too??

-    warn_ $1
+    warn_ "$ME_: failed test: $@"

Thanks & have a nice day,
Berny