Re: [PATCH] maint: be less strict about executable permissions of tests

[Pádraig Brady]

On 04/03/15 22:26, Bernhard Voelker wrote:
> With "umask 0027" or even "umask 0077", the git clone of coreutils
> does not have the executable bit set for 'other' (or 'group).
> Therefore, "make syntax-check" would fail.
> 
> * cfg.mk (sc_tests_executable): Change the -perm argument of find(1)
> to only print the names of the files which are not executable by the
> user, rather than insisting on ugo+x (octal 111).
> ---
>  cfg.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cfg.mk b/cfg.mk
> index ab0b8a4..d65af27 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -118,7 +118,7 @@ sc_tests_list_consistency:
>  sc_tests_executable:
>       @test_extensions_rx=`echo $(TEST_EXTENSIONS)                    \
>         | sed -e "s/ / -o -name */g" -e "s/^/-name */"`; \
> -     find tests/ \( $$test_extensions_rx \) \! -perm -111 -print \
> +     find tests/ \( $$test_extensions_rx \) \! -perm -u+x -print \
>         | sed -e "s/^/$(ME): Please make test executable: /" | grep . \
>           && exit 1; :

Nice one.

thanks,
Pádraig.