[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] maint: fix wildcard quoting in sc_tests_executable
From: |
Pádraig Brady |
Subject: |
[PATCH] maint: fix wildcard quoting in sc_tests_executable |
Date: |
Fri, 20 Mar 2015 01:22:52 +0000 |
* cfg.mk (sc_tests_executable): If there are files with
$TEST_EXTENSIONS in the current directory, then the
lack of quoting of the $test_extensions_rx contents
could result in globbing and an inconsequential run.
find(1) produces warnings only with more than one expansion.
---
cfg.mk | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index d65af27..a3b0e8e 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -116,10 +116,9 @@ sc_tests_list_consistency:
# Ensure that all version-controlled test scripts are executable.
sc_tests_executable:
- @test_extensions_rx=`echo $(TEST_EXTENSIONS) \
- | sed -e "s/ / -o -name */g" -e "s/^/-name */"`; \
- find tests/ \( $$test_extensions_rx \) \! -perm -u+x -print \
- | sed -e "s/^/$(ME): Please make test executable: /" | grep . \
+ @test_extensions_rx=`printf -- "-name '*%s' " $(TEST_EXTENSIONS)`;\
+ find tests/ \( $$test_extensions_rx \) \! -perm -u+x -print \
+ | sed -e "s/^/$(ME): Please make test executable: /" | grep . \
&& exit 1; :
# Ensure all gnulib patches apply cleanly
--
2.1.0
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] maint: fix wildcard quoting in sc_tests_executable,
Pádraig Brady <=