Re: [PATCH] maint: avoid a new -Werror=return-type warning in yes.c

[Bernhard Voelker]

On 04/29/2015 12:10 AM, Pádraig Brady wrote:
> * src/yes.c (main): Simplify the logic so that the
> compiler can see this function always returns a value.
> This was seen with GCC 5.0 in SINGLE_BINARY mode.
> ---
>  src/yes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/yes.c b/src/yes.c
> index 3b7b4c6..07885be 100644
> --- a/src/yes.c
> +++ b/src/yes.c
> @@ -115,7 +115,7 @@ main (int argc, char **argv)
>  
>    /* If the data doesn't fit in BUFSIZ then output
>       what we've buffered, and iterate over the remaining items.  */
> -  while (i != argc)
> +  while (true /* i != argc */)
>      {
>        int j;
>        if ((pbuf - buf) && fwrite (buf, pbuf - buf, 1, stdout) != 1)
> 

Nice one!

Thanks & have a nice day,
Berny