|
From: | Pádraig Brady |
Subject: | query on system.h include order check |
Date: | Mon, 18 May 2015 12:34:58 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
The commit message here doesn't explain why this was done: http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=SH-UTILS-2_0_12-112-g13221a5 Why not just include <sys/types.h> in system.h? Would this be better served these days with a syntax-check? Note I introduced a typo in the last change to this macro in 2011 which effectively avoided this check entirely (notice the triple underscore in http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.9-10-ge1aaf89) So should we just remove this check? cheers, Pádraig.
[Prev in Thread] | Current Thread | [Next in Thread] |