[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] yes: avoid redundant diagnostics on write error
|
From: |
Bernhard Voelker |
|
Subject: |
Re: [PATCH] yes: avoid redundant diagnostics on write error |
|
Date: |
Tue, 5 Apr 2016 11:12:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 04/04/2016 02:20 PM, Pádraig Brady wrote:
> * src/yes.c (main): For large inputs only write a single
> diagnostic for write errors.
> * tests/misc/yes.sh: Test when /dev/full is available.
Nice catch!
The patch per se LGTM ... but while at it, you may want to fix this
in tests/misc/yes.sh (right before your addition):
+ external true 1 2 3 4 5 6[...] 3998 3999 4000
./tests/misc/yes.sh: line 35: external: command not found
Introduced in v8.24-82-gf720844.
Thanks & have a nice day,
Berny