Re: [PATCH] test: Add unary operator -E: test that a file is an empty directory

[Eric Blake]

On 04/06/2016 12:00 PM, Mattias Andrée wrote:
>> You may want to check
>> that your top-level ~/.gitconfig has these settings:
>>
>> [user]
>>     name = "Full Name"
>>     email = address@hidden
>> [sendemail]
>>     from = Full Name <address@hidden>
>>
>> so that 'git send-email' won't be forced to assume
>> authorship is different than mail sender.
>>
> 
> That fixed the problem. Thanks.
> 
> Feels a bit pedantic that you have too specify
> the from value completely. One would think that
> it could figure it out.

The user.name and user.email are mandatory; they determine git authorship.

I think the sendemail.from is optional, but if omitted, it then uses
your outgoing mailer's defaults (and not all outgoing mailers have sane
defaults).  So I've always provided it myself, rather than worrying
about how to (re-)configure my SMTP connection to provide a default
From: that matches my wishes.  The other reason sendemail.from is
important is that sometimes you send someone else's patch, where the
mail is from you but the authorship From: line must be listed; so git
_can't_ always use the authorship information in generating the email
envelope.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature