Re: expand/unexpand: add tests, refactor common code

[Pádraig Brady]

On 25/06/16 07:44, Assaf Gordon wrote:
> Hello,
> 
> The attached patches add more tests to expand/unexpand,
> then incrementally extract common functionality into a new module 
> 'expand-common.h'.
> (The patches could be squashed before finalizing them, but easier to follow 
> when separate).
> 
> This could later serve as a basis for trying to add multibyte handling...

Very nice work, especially adding new tests.
Yes these should probably be squashed before pushing.
Attached is a trivial patch to pass syntax-check.

Size increase is negligible:

lt:coreutils (master)$ size src/{,un}expand
   text    data     bss     dec     hex filename
  39360    1108     496   40964    a004 src/expand
  39890    1116     528   41534    a23e src/unexpand

lt:coreutils (expand *)$ size src/{,un}expand
   text    data     bss     dec     hex filename
  39792    1108     512   41412    a1c4 src/expand
  40298    1116     512   41926    a3c6 src/unexpand

As part of this, or at least before looking at multibyte changes,
it would be worth considering this proposal for changing the
unexpand algorithm: http://bugs.gnu.org/23335

thanks!
Pádraig

expand-extern.diff
Description: Text Data