[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: avoid a signed overflow warning in ptx
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH] build: avoid a signed overflow warning in ptx |
|
Date: |
Mon, 18 Dec 2017 03:29:26 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 17/12/17 08:28, Erik Auerswald wrote:
> Hi,
>
> On Sat, Dec 16, 2017 at 01:11:35PM -0800, Pádraig Brady wrote:
>> * src/ptx.c (fix_output_parameters): GCC 6.3.1 with
>> ./configure --enable-single-binary would give:
>> error: assuming signed overflow does not occur
>> when simplifying conditional to constant [-Werror=strict-overflow]
>> if (file_index > 0)
>> So change the type of file_index to signed (size_t).
>
> But you changed it from _signed_ (int) to _unsigned_ (size_t), right?
Right. Sorry for the incorrect comment.
cheers,
Pádraig