Re: new snapshot available: coreutils-8.29.57-2ed7c2.tar.xz

[Assaf Gordon]

Hello Pádraig and all,

First,
thanks for all the hard work regarding the env-S test failure.
The shebang length limit is an interesting edge-case I haven't thought 
about...


Second,
Attached few test failures (not env-S-script/shebang ones).

======

On Debian 8.10/i686 (this is gcc45.fsffrance.org from gcc copmile farm):

  FAIL: tests/cp/fiemap-perf

This is a false-positive due to the test assuming that
copying 1TB of sparse file will finish in less than 10 seconds:
https://opengrok.housegordon.com/source/xref/coreutils/tests/cp/fiemap-perf.sh#42

Was previously reported for 8.29:
https://lists.gnu.org/archive/html/coreutils/2017-12/msg00059.html

A bit more information this time:

  $ timeout 10 truncate -s1T f
  $ ls -lh f*
  -rw-r--r-- 1 agn agn 1.0T Jun 26 12:01 f
  $ timeout 10 cp f f2 ; echo $? 


  124

strace shows that the 'ioctl(FS_IOC_FIEMAP)' did not terminate within 10 
seconds. Perhaps it's a slow machine - gcc45 is "AMD Athlon(tm) II X4 
640 Processor".

=====

On Debian 9.4/x86_64:

   FAIL: tests/df/df-symlink

This is a false-positive, on my system /tmp is bind-mounted to /scratch
(which is mounted from /dev/sdb2):

  ++ grep -F /dev/sdb2
  ++ wc -l
  + test 1 = 1
  + df --out=source,target .
  + compare exp out
  + compare_dev_null_ exp out
  + test 2 = 2
  + test xexp = x/dev/null
  + test xout = x/dev/null
  + return 2
  + case $? in
  + compare_ exp out
  + diff -u exp out
  --- exp 2018-06-25 05:16:53.034770806 -0600
  +++ out 2018-06-25 05:16:53.042771018 -0600
  @@ -1,2 +1,2 @@
   Filesystem     Mounted on
  -/dev/sdb2      /tmp
  +/dev/sdb2      /scratch
  + fail=1

=====

On OpenBSD 6.2/amd64, few test failures:

FAIL: tests/misc/env

seems like "env -" does not work. I will investigate further
(perhaps I've broken something with the changes to the command-line 
processing?).

  $ ./src/env --version
  env (GNU coreutils) 8.29.57-2ed7c2
  Copyright (C) 2018 Free Software Foundation, Inc.
  License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses 
/gpl.html>.
  This is free software: you are free to change and redistribute it.
  There is NO WARRANTY, to the extent permitted by law.

  Written by Richard Mlynarik, David MacKenzie, and Assaf Gordon.

  $ ./src/env -
  env: invalid option -- '-'
  Try './src/env --help' for more information.


FAIL: tests/misc/env-S

fails for the same reason:

  env-S.pl: test err_sp1: stderr mismatch, comparing err_sp1.1 
(expected) and err_sp1.E (actual)
  *** err_sp1.1   Mon Jun 25 04:41:28 2018
  --- err_sp1.E   Mon Jun 25 04:41:28 2018
  ***************
  *** 1,2 ****
  ! env: invalid option -- '-'
    Try 'env --help' for more information.
  --- 1,2 ----
  ! env: unknown option -- S cat -n
    Try 'env --help' for more information.


   FAIL: tests/misc/env-S

fails like other systems.


Also one ERROR:

  ERROR: tests/misc/usage_vs_getopt
  =================================

  using SHELL=/bin/sh with 'set -x' corrupts stderr
  chroot: unknown option -- thisoptiondoesnotexist
  usage_vs_getopt.sh: set-up failure:
  ERROR tests/misc/usage_vs_getopt.sh (exit status: 99)

I believe this is a false-positive.
The "framework_failure_" is triggered
when testing an invalid short option on line 37:
https://opengrok.housegordon.com/source/xref/coreutils/tests/misc/usage_vs_getopt.sh#37

Programs are tested like so:

     chroot -/

Then "grep" searches for "'/'" in STDERR (i.e. 
single-quote,slash-single-quote).

On this system (OpenBSD 6.2 with C locale), the error message does
not contain single-quotes and the 'grep' fails.
This happens in all programs:

  $ ./src/env --version | head -n1
  env (GNU coreutils) 8.29.57-2ed7c2
  $ ./src/env -/
  env: unknown option -- /
  Try './src/env --help' for more information.

  $ ./src/chroot --version | head -n1
  chroot (GNU coreutils) 8.29.57-2ed7c2
  $ ./src/chroot -/
  chroot: unknown option -- /
  Try './src/chroot --help' for more information.

Attached is a possible patch to avoid the failure.

Interesting, just below the modified "grep" in "usage_vs_getopt.sh"
there's a "sed" invocate that also searches for the pattern (line 40 ,
https://opengrok.housegordon.com/source/xref/coreutils/tests/misc/usage_vs_getopt.sh#40 
).
I did not modify it, and the tests still pass - I don't think it is 
actually used (the "pat" file isn't checked).

======

More tests to follow soon.

regards,
 - assaf

Debian_8.10_i686--tests-suite-summary.log
Description: Text Data

Debian_8.10_i686--fiemap-strace.log.gz
Description: application/gzip

Debian_9.4_x86_64CCclang-3.8--tests-suite-summary.log.gz
Description: application/gzip

OpenBSD_6.2_amd64--tests-suite-summary.log.gz
Description: application/gzip

0001-tests-accept-getopt-errors-without-single-quotes.patch
Description: Text Data