[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/4] stat: only set STATX_* mask bits for things we want t
|
From: |
Jeff Layton |
|
Subject: |
Re: [PATCH v4 3/4] stat: only set STATX_* mask bits for things we want to print |
|
Date: |
Mon, 13 May 2019 06:44:14 -0400 |
|
User-agent: |
Evolution 3.32.2 (3.32.2-1.fc30) |
On Fri, 2019-05-10 at 02:28 -0700, Pádraig Brady wrote:
> On 01/05/19 06:57, Jeff Layton wrote:
> > Scan the format string to build a STATX_* mask prior to calling statx.
> > This allows us to avoid setting bits for attributes that we don't
> > intend to display, which can mean a much lighter-weight operation on
> > some filesystems.
>
> Do we have more details/measurements of the wins here?
>
No real numbers, no.
With CephFS (or even NFS), this allows the client to avoid communicating
with the server in some cases. In the event that the client does need to
talk to the server, the server may be able to avoid recalling delegated
state from other clients when one client doesn't need a full compliment
of attributes.
I could probably craft a benchmark that would show an improvement here
on a filesystem like CephFS, but it would be pretty synthetic and I'm
not sure it'd tell us much about real-world workloads.
--
Jeff Layton <address@hidden>