[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [musl] Re: date-debug test failure with musl
|
From: |
Assaf Gordon |
|
Subject: |
Re: [musl] Re: date-debug test failure with musl |
|
Date: |
Mon, 13 May 2019 16:49:52 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
Hello,
On 2019-05-13 12:23 p.m., Rich Felker wrote:
On Mon, May 13, 2019 at 05:02:48AM +0200, Niklas Hambüchen wrote:
Dear coreutils maintainers,
when compiling coreutils commit 6e97d36 against musl v1.1.22 on Ubuntu, I get a
test failure and differing output than when using glibc.
Thank you for the report,
[...]
As long as coreutils' date is producing the desired "invalid" error
either way, which it seems to be, I think it's a mistake that the
debug output for "normalized time" is being compared as part of the
test assertion. Only the result should matter, not the path by which
it's reached.
And thank you Rich for the quick analysis.
The attached patch implements your suggestion.
It works on glibc, please give it a test on your Ubuntu/musl-1.1.22 system.
regards,
- assaf
0001-tests-avoid-false-positive-in-date-debug-test.patch
Description: Text Data